Dream cards and fixes#6
Open
sharpobject wants to merge 3 commits into
Open
Conversation
Dream cards use string IDs with a "D" prefix (e.g. "D11011"). Changes: - SortableCard: Fix image path to use String(card_id).slice(0,-1)+level instead of arithmetic (which produced NaN for D-prefix IDs). Show 5 stars for dream cards instead of 3. Add level clamping with does_not_exist check when switching cards. - Simulator buildTree: Add branch for D-prefix IDs that routes them to a "Fate Branches" category in the TreeSelect. - App.css: Add aspect-ratio on card images for consistent heights.
…card levels - Force tree select dropdown text to white in dark mode via CSS - Add optionFilterProp="label" to Character and Side job selects so search filters by name instead of numeric ID - Ignore clicks on card star levels that don't exist in swogi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.