Fix raw CLIXML progress output in diagnostic reports - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents PowerShell progress records from leaking into the report's Errors and warnings section as raw
#< CLIXML/<Objs ...>data.Cause
When diagnostic modules run in a redirected child PowerShell process, progress records produced by PowerShell/storage cmdlets can be serialized to stderr as CLIXML. The report runner currently treats stderr as ordinary text, so that serialization is copied verbatim into reports.
Fix
$ProgressPreference = 'SilentlyContinue'inside the diagnostic child process before invoking a module;Write-Progressand verifies normal stdout is preserved and no CLIXML leaks intoErrorLines.Progress output is transient UI state and is not useful diagnostic evidence, so suppressing it does not remove report findings or actual warning/error output.