Add per-client-IP rate limiting and auth-failure lockout#76
Merged
Conversation
Add token-bucket rate limiter (via golang.org/x/time/rate) and auth-failure lockout to protect against request floods and brute-force attacks. Both are always enabled with configurable parameters. Lockout returns HTTP 429 for generic endpoints and the DynDNS2 'abuse' token for /nic/update. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
0xFelix
force-pushed
the
ratelimit-lockout
branch
from
34f7294 to
93f5c9f
Compare
The test server configs had zero-value RateLimit and Lockout fields, causing all requests to be rate-limited immediately. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
Add RATE_LIMIT_IDLE_SECONDS / rateLimit.idleSeconds config option to control how long an inactive client's token bucket is kept before being swept. Defaults to 600 seconds (10 minutes). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x/time/rate) and auth-failure lockout per client IPabusetoken for /nic/update)Test plan
make testpasses (config, lockout, limiter tests)make lintpasses (0 issues)make buildsucceeds🤖 Generated with Claude Code