config: make enabled endpoints configurable#79
Merged
Conversation
Add an Endpoints struct to Config with bool fields for each endpoint group (plain, nic, acmedns, httpreq, directadmin). All endpoints are enabled by default. A custom UnmarshalYAML implementation ensures that explicitly listing endpoints in YAML disables all others, matching the env var semantics of ENDPOINTS=plain,nic. Also extract envRateLimit and envLockout helpers to stay within the cyclomatic complexity limit. Signed-off-by: Felix Matouschek <felix@matouschek.org> Signed-off-by: 0xFelix <felix@matouschek.org>
Signed-off-by: Felix Matouschek <felix@matouschek.org> Signed-off-by: 0xFelix <felix@matouschek.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Endpointsstruct toConfigwithboolfields for each endpoint group:plain,nic,acmedns,httpreq,directadminUnmarshalYAMLonEndpointsensures consistent semantics: if theendpoints:key is present in YAML, only explicitly-set-truefields are enabled — matching the env var behaviorENDPOINTSenv var accepts a comma-separated list (e.g.ENDPOINTS=plain,nic); if unset, all endpoints remain activeenvRateLimitandenvLockouthelpers to stay within the cyclomatic complexity limitConfiguration examples
YAML:
Environment:
Both have identical semantics: if specified, only listed endpoints are registered; if omitted entirely, all are active.
Test plan
make lint— 0 issuesmake test— 18/18 passedmake functest— 68/68 passed🤖 Generated with Claude Code