middleware: return after JSON decode error in BindHTTPReq#82
Merged
Conversation
Without the return, a decode failure wrote a 400 header and fell through to the d.FQDN check, triggering a superfluous WriteHeader call and emitting a misleading 'fqdn is missing' body. Signed-off-by: 0xFelix <felix@matouschek.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BindHTTPReqinpkg/middleware/bind.gowas missing areturnafter writing a 400 header on JSON decode failure.d.FQDN == \"\"check, which calledhttp.Erroragain and produced a superfluousWriteHeaderlog plus a misleadingfqdn is missingbody.Bind*handlers return correctly in the analogous spot; this alignsBindHTTPReqwith them.Test plan
make lintmake test(18/18 pass)make functest(68/68 pass)