Conversation
- README env table listed API_TIMEOUT default as 15 seconds, but NewConfig sets it to 60. Matches the yaml example above the table. - AGENTS.md overview enumerated the supported DNS API protocols but omitted DynDNS2 (/nic/update), which has been wired up for a while. Signed-off-by: 0xFelix <felix@matouschek.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.md: env-var table listedAPI_TIMEOUTdefault as15 seconds.NewConfigsetsTimeout: 60(pkg/config/config.go:133), which also matches thetimeout: 60in the YAML example above the table.AGENTS.md: overview enumerated "lego HTTP request, ACMEDNS, DirectAdmin Legacy, plain HTTP" but omitted DynDNS2 (/nic/update), which is wired up inpkg/app/app.goand documented in the README endpoint table.Test plan