fix: repoint two 404 external links in builder docs - #356
Open
pucedoteth wants to merge 1 commit into
Open
Conversation
The React SDK moved out of miden-client into web-sdk, so the linked path 404s: https://github.com/0xMiden/miden-client/blob/v0.15.0/packages/react-sdk/README.md -> 404 https://github.com/0xMiden/web-sdk/blob/v0.15.9/packages/react-sdk/README.md -> 200 Rebased onto current main. The Foundry scripting link this branch also repointed has since been fixed upstream, so that hunk is dropped.
pucedoteth
force-pushed
the
fix-broken-external-links
branch
from
August 18, 2026 23:14
6df6dbb to
59a670a
Compare
Author
|
Rebased onto current The Foundry scripting link this branch also repointed has since been fixed upstream ( The remaining fix is still needed — the React SDK moved out of (verified just now with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two links in
docs/return 404. Both verified withcurlbefore and after, per the URL rule in CLAUDE.md.1. Foundry scripting guide
docs/builder/get-started/your-first-smart-contract/deploy.md:42Foundry moved the page. Their own
llms.txtlists the current one:which matches what the sentence is pointing at ("executable Rust binaries that handle all your contract interactions").
https://getfoundry.sh/guides/itself is still 200, so only the leaf moved.2. React SDK README
docs/builder/tools/clients/react-sdk/account-state-and-balances.md:25The tag
v0.15.0does exist onmiden-client, but there is nopackages/directory in that repo — not at that tag, and not on its default branch. The React SDK lives inweb-sdk:@miden-sdk/reacton npm (latest0.15.9, matching this docs line) declaresrepository: git+https://github.com/0xMiden/web-sdk.git0xMiden/web-sdk/packages/react-sdk/README.mdexists and is 56 KBPinned to
v0.15.9— the latest0.15.xtag, preserving the original intent to pin rather than track a moving branch.v0.15.0is not a tag onweb-sdk(its tags start atv0.15.4). Link text updated frommiden-client/...toweb-sdk/...so it still names the file it points at.Notes
npm run builddoes not complete on a bare clone. It fails insidebars.tswithThese sidebar document ids do not exist:forbuilder/tools/bridging/*,builder/tools/clients/rust-client/*and friends — the docs thatdeploy-docs.ymlingests from external repos before building. I confirmed the failure is identical on untouchedmain, so it is pre-existing and not from this change. Both edits here are external absolute URLs, which Docusaurus'sonBrokenLinksdoes not check, so they cannot affect the build either way. Flagging it in case a documented local-build path (or an ingest script) would be worth having.versioned_docs/left untouched. The same two links appear in the snapshots (version-0.11throughversion-0.15). Those are generated by the cut-versions workflow, so fixingdocs/is what makes future cuts correct; happy to update the snapshots too if you'd rather they were consistent.0xMiden/miden-tutorials→tutorials,0xMiden/miden-node/discussions→node/discussions, and0xMiden/miden-client/issues→rust-sdk/issues. They all resolve today so I left them out of this PR, but the last one in particular suggests the same repo-reorg drift as fix Consolidated Miden docs in this repo #2. Say the word and I'll fold them in.