fix: build PATH with platform separators - #229
Open
dumanoglu1 wants to merge 1 commit into
Open
Conversation
dumanoglu1
marked this pull request as ready for review
August 12, 2026 17:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Config::execute_commandnow prepends entries toPATHwithstd::env::split_pathsandstd::env::join_pathsinstead of formatting a hard-coded:separator.A small unit test covers that the helper preserves platform-specific path separators when prepending an entry.
Why
Windows uses
;as thePATHseparator. The previous string formatting created malformedPATHvalues on Windows when adding the active toolchainopt/directory or an overriddenCARGO_HOME/bin.Fixes #227
Validation
cargo checkcargo test prepending_a_path_entry_preserves_platform_separatorswas attempted, but the repository's current Windows test build fails first in unrelated test modules that callstd::os::unix::fs::symlinkfromsrc/migrate_networks.rsandsrc/networks.rs.