fix settings row count errors - #2382
Open
UfukNode wants to merge 1 commit into
Open
Conversation
UfukNode
force-pushed
the
ufuk/fix-settings-row-count-errors
branch
2 times, most recently
from
August 13, 2026 21:16
f3a9637 to
11b9356
Compare
UfukNode
force-pushed
the
ufuk/fix-settings-row-count-errors
branch
from
August 26, 2026 00:28
11b9356 to
5aa70ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2350.
Rebased this on the current
nextbranch and moved the row-count check into the newsettings.rsmodule. Sinceremove_settingnow returnsfalsefor a missing key, this keeps the fix scoped to setting writes.Checked locally:
RUSTC=$(rustup which --toolchain 1.96 rustc) rustup run 1.96 cargo test -p miden-client-sqlite-store set_setting_reports_unexpected_row_countRUSTFMT=$(rustup which --toolchain nightly rustfmt); "$RUSTFMT" --check crates/sqlite-store/src/settings.rs crates/sqlite-store/src/lib.rs crates/rust-client/src/store/errors.rsTOOLCHAIN_BIN=$(dirname "$(rustup which --toolchain 1.96 rustc)"); PATH="$TOOLCHAIN_BIN:$PATH" RUSTC="$TOOLCHAIN_BIN/rustc" rustup run 1.96 cargo clippy -p miden-client-sqlite-store --all-targets -- -D warningsNO_CHANGELOG_LABEL=false BASE_REF=next ./scripts/check-changelog.sh