fix(cli): require file path for import - #2450
Open
UfukNode wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miden-client importaccepted an empty invocation because the filename list was optional, so it initialized the client and exited successfully without importing anything.This makes the filename argument required and adds it to the existing empty-command CLI regression test.
Testing:
cargo test -p miden-client-cli --test integration cli_empty_commands -- --exact --nocapture./target/debug/miden-client import./target/debug/miden-client import --helpcargo clippy -p miden-client-cli --all-targets -- -D warnings