Skip to content

chore: address followup comments for node 0.16 update - #2475

Open
juan518munoz wants to merge 3 commits into
nextfrom
jmunoz-node-update-followup
Open

chore: address followup comments for node 0.16 update#2475
juan518munoz wants to merge 3 commits into
nextfrom
jmunoz-node-update-followup

Conversation

@juan518munoz

@juan518munoz juan518munoz commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Closes #2473

  1. CHANGELOG fix: The five entries that pointed at issue Update node to 0.16 #2360/chore: update node to 0.16 #2431 now cite PR chore: update node to 0.16 #2431. The GetAccount behavior entry was dropped per your earlier decision.
  2. Pass SyncedNote to observer: NoteObserver::observe now takes &SyncedNote.
  3. Flatten SyncedNote: flattened to note_id, metadata, inclusion_proof, details, attachments.
  4. "Is the first check covered by the second?": the validation now verifies set equality: every requested key must appear in the response, and the response must not contain unrequested keys.
  5. Attachment parsing hard to follow: simplified using the ReportedAttachment enum and ReportedAttachments::from_reports.
  6. Reintroduce ResolvedNoteContent: superseded by the flatten of point 3.
  7. Hardcode insecure key: the runtime keygen in scripts/start-test-node.sh was replaced by three hardcoded insecure test-only keys.

@juan518munoz
juan518munoz force-pushed the jmunoz-node-update-followup branch from 19dfecf to 7910877 Compare September 1, 2026 13:03
@juan518munoz
juan518munoz marked this pull request as ready for review September 1, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update node to 0.16 - pending followups

1 participant