feat(rust-client): distinct error for submissions with an unknown outcome - #2498
Open
sofiazcoaga wants to merge 3 commits into
Open
feat(rust-client): distinct error for submissions with an unknown outcome#2498sofiazcoaga wants to merge 3 commits into
sofiazcoaga wants to merge 3 commits into
Conversation
sofiazcoaga
force-pushed
the
feat/indeterminate-submission-error
branch
from
September 4, 2026 15:34
a70c9b8 to
d92e77b
Compare
sofiazcoaga
marked this pull request as ready for review
September 4, 2026 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A transaction submission can fail without the node saying whether it processed the transaction. Those failures reach the caller as
ClientError::RpcError, the same shape as any other network error. The caller cannot tell "the node rejected this" from "this may be in the mempool right now", and has nothing to check with:submit_new_transactionruns execute, prove and submit internally, so thetransaction idand theProvenTransactionare dropped when the submit fails. Re-running the request is not a recovery, it builds a different transaction with different note serial numbers and a different id.Changese
ClientError::SubmissionOutcomeUnknown, carrying theProvenTransactionand the originatingRpcError, plus anErrorHint.Client::submit_proven_transactionreturns it when the submission failed without a definite answer. Every other failure keeps arriving asClientError::RpcError.RpcError::is_indeterminate_submissiondecides that. It lists the codes the node issues deliberately and treats everything else as indeterminate, so a code this client does not recognize stays on the "may have landed" side.Code matching
ClientError::RpcErrorfor submission failures still compiles and stops matching these cases. Callers that only propagate or log need no change.