feat(accounts): multi-account support — switcher, add-account flow with recovery choice - #804
Draft
0xnullifier wants to merge 138 commits into
Draft
feat(accounts): multi-account support — switcher, add-account flow with recovery choice#8040xnullifier wants to merge 138 commits into
0xnullifier wants to merge 138 commits into
Conversation
… and plus, public/private picker with guardian-or-local recovery step, local-risk acknowledgment flow
…n scan, recovered-accounts overview, scan-more extension
0xnullifier
force-pushed
the
feat/multi-account-support
branch
from
September 2, 2026 09:27
ff4a92a to
25766b4
Compare
…pport # Conflicts: # .github/actions/inject-linked-guardian-pr/action.yml # .github/actions/install-miden-client-cli/action.yml # .github/actions/run-local-node/action.yml # .github/workflows/e2e-blockchain.yml # .github/workflows/warm-node-cache.yml # playwright/e2e/helpers/miden-cli.ts # playwright/e2e/local-stack/versions.env # playwright/e2e/tests/fee-accounting.spec.ts # public/_locales/de/de.json # public/_locales/de/messages.json # public/_locales/en/en.json # public/_locales/en/messages.json # public/_locales/en_GB/en_GB.json # public/_locales/en_GB/messages.json # public/_locales/es/es.json # public/_locales/es/messages.json # public/_locales/fr/fr.json # public/_locales/fr/messages.json # public/_locales/ja/ja.json # public/_locales/ja/messages.json # public/_locales/ko/ko.json # public/_locales/ko/messages.json # public/_locales/pl/messages.json # public/_locales/pl/pl.json # public/_locales/pt/messages.json # public/_locales/pt/pt.json # public/_locales/ru/messages.json # public/_locales/ru/ru.json # public/_locales/tr/messages.json # public/_locales/tr/tr.json # public/_locales/uk/messages.json # public/_locales/uk/uk.json # public/_locales/zh_CN/messages.json # public/_locales/zh_CN/zh_CN.json # public/_locales/zh_TW/messages.json # public/_locales/zh_TW/zh_TW.json # src/app/pages/Receive/PendingTab.tsx # src/app/templates/HomePrompts.tsx # src/lib/miden/guardian/direct-switch.test.ts # src/lib/miden/guardian/index.test.ts # src/lib/miden/guardian/index.ts # src/lib/miden/sdk/helpers.ts # src/lib/miden/transaction/constants.ts # src/lib/miden/transaction/index.ts # src/lib/miden/transaction/initiate.ts # src/lib/miden/transaction/transactions.guardian.test.ts # src/screens/send-flow/SendManager.test.tsx # src/screens/send-flow/SendManager.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Multi-account support on the home view:
Account N · address) with a chevron opens the account switcher; a standalone copy icon keeps address copying; a new "+" button starts the add-account flow.WalletType.OnChainaccount immediately; Private swaps to a recovery-choice step — Guardian (routes to the operator picker at/add-account/guardian) or Fully Private (routes to/add-account/private)./add-account/private): three sequential screens, each stating one consequence of a guardian-less account (device loss = permanent fund loss even with the seed phrase saved), each with an "I understand" primary CTA and a "Use a Guardian instead" escape hatch. The final confirm creates theOffChainaccount.Plumbing
CreateAccountRequestcarries an optionalguardianEndpoint, threaded through both dispatchers →Actions.createHDAccount→Vault.createHDAccount; an explicitly chosen endpoint wins over the guardian-sibling default.ChooseGuardianScreengains asubmitLoadingprop (spinner + re-tap guard on Continue) for callers that create in place.Testing
yarn tsc --noEmitclean;yarn lint:i18nclean.src/components/uisuites pass (AccountsDrawer tests updated for the switch list; barrel test covers the new drawer).