fix(react-sdk): detect note status changes in setNotesIfChanged - #351
Open
kutluhaneth46 wants to merge 1 commit into
Open
fix(react-sdk): detect note status changes in setNotesIfChanged#351kutluhaneth46 wants to merge 1 commit into
kutluhaneth46 wants to merge 1 commit into
Conversation
Compare id plus lifecycle flags (consumed/processing/inclusion-pending) so useNotes/useNoteStream re-render when a note transitions without an ID set change. Fixes 0xMiden#304. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Portable note-status fingerprint helper (mirrors this PR): https://github.com/kutluhaneth46/miden-dev-survival-kit/blob/main/src/note-fingerprint.ts — feedback welcome if the semantics match what you want upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setNotesIfChanged/setConsumableNotesIfChangednow fingerprint notes byidplus lifecycle flags (isConsumed,isProcessing,isInclusionPending) instead of ID membership alone.useNotes()/useNoteStream()kept rendering pending status after a note was consumed on-chain.Closes #304.
Test plan
npx vitest run src/__tests__/store/MidenStore.test.tsinpackages/react-sdk(40/40 pass)