fix(web-client): latch worker failures so later calls fail fast - #358
Open
kutluhaneth46 wants to merge 1 commit into
Open
fix(web-client): latch worker failures so later calls fail fast#358kutluhaneth46 wants to merge 1 commit into
kutluhaneth46 wants to merge 1 commit into
Conversation
A dead worker only had a message listener, so load/runtime failures left ready and pendingRequests hanging. Latch workerFailure, handle error/messageerror, and reject subsequent callMethodWithWorker calls. Fixes 0xMiden#315 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebClientonly listened formessage, so a worker load/parse crash or uncaught worker error leftreadyandpendingRequestshanging forever.workerFailure, handleerror/messageerror(preventDefault), flush in-flight requests, and reject latercallMethodWithWorkercalls immediately.workerFailure.jswith unit tests (emptyevent.messagevs load failure, idempotent second failure).Fixes #315
Test plan
pnpm test:unit -- js/__tests__/workerFailure.test.jsincrates/web-clientcallMethodWithWorkerafter latch rejects with the same error instead of hanging.