fix(react): resolve native AuthScheme enum via getWasmOrThrow in initializeSignerAccount - #366
Open
huklaa wants to merge 1 commit into
Open
fix(react): resolve native AuthScheme enum via getWasmOrThrow in initializeSignerAccount#366huklaa wants to merge 1 commit into
huklaa wants to merge 1 commit into
Conversation
…ializeSignerAccount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #277.
initializeSignerAccountwas reading the friendly string-valuedAuthSchemeexport from@miden-sdk/miden-sdkand passingAuthScheme.AuthEcdsaK256Keccakto the raw wasm-bindgen auth-component constructor. That member does not exist on the friendly export, so the call receivedundefined.This change resolves the native numeric enum via the public
getWasmOrThrow()accessor and useswasm.AuthScheme.AuthEcdsaK256Keccakinstead.Regression coverage updates the local mock to match the real public
AuthSchemeshape and verifies the auth component is built with the native enum. The full React SDK coverage suite passed in the agent sandbox (845/845 tests, coverage thresholds met), along with lint and Prettier checks. Typecheck only reported the same pre-existing unresolved@miden-sdk/miden-sdkpackage issue seen on main.A final duplicate check found no competing open PR for #277 immediately before opening this PR.