fix(web-client): keep Buffer args for Node deserialize - #368
Open
kutluhaneth46 wants to merge 1 commit into
Open
fix(web-client): keep Buffer args for Node deserialize#368kutluhaneth46 wants to merge 1 commit into
kutluhaneth46 wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Buffer/Uint8Arrayarguments into plain arrays.Buffer, which napiBuffer/ JsBytes APIs (AuthSecretKey.deserialize,Word.deserialize, etc.) require.Vec<u8>parameters still acceptBuffer, so constructors likerpoFalconWithRNGkeep working.Fixes #364
Test plan
pnpm --filter @miden-sdk/miden-sdk run test:unit -- js/__tests__/napi-compat.test.jsAuthSecretKey.serialize()→Buffer.from(..., "base64")→AuthSecretKey.deserialize(...)via the public package export (notgetNativeModule())Word.deserializeUint8Arrayseeds still work forAuthSecretKey.rpoFalconWithRNG