Skip to content

server: validate the backend before binding the port #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CryptVenture wants to merge 1 commit into from
Closed

server: validate the backend before binding the port #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions app/server/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,21 @@ int main(int argc, char ** argv) {
throw std::runtime_error("--min-free-memory-mb must be >= 0 (0 disables the memory guard)");
}

// Prove the requested backend and device exist before binding a port.
// The backend defaults to CUDA, and nothing else checks it until the
// first generate, so a machine without CUDA would otherwise serve the
// whole UI — health, model list, downloads — and only fail once the
// user pressed Run. Failing here reports the same message the engine
// would have raised, at the point the operator can still act on it.
{
engine::core::BackendConfig probe;
probe.type = config.backend;
probe.device = config.device;
probe.threads = config.threads;
ggml_backend_t backend = engine::core::init_backend(probe);
ggml_backend_free(backend);
}

const auto ui_resource_anchor = executable_directory(argc > 0 ? argv[0] : nullptr);
minitts::server::ServerState state(
config,
Expand Down
Loading