feat: editor visual settings (#928) + soroban-sdk deprecation checker (#933)#940
Merged
0xVida merged 1 commit intoJun 2, 2026
Merged
Conversation
|
@Salmatcre8 is attempting to deploy a commit to the vidatg's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Salmatcre8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related editor/extension UX features for the v-next milestone:
Closes #928
Closes #933
#928 — Monaco minimap & guide settings (
ide/)Adds visual toggles in Settings → Editor for code-readability features, each persisting to the
UserSettingsStore(zustand + localStorage).ide/src/components/settings/EditorVisualSettings.tsx— minimap, indent-guide, and font-ligature toggles using the existingSwitchUI.useUserSettingsStore.ts— addseditorMinimap(default off),editorIndentGuides(on),editorFontLigatures(on) + setters; persisted under the existinguser-settingskey.SettingsModal.tsx— renders<EditorVisualSettings />in the Editor tab.CodeEditor.tsx— Monacooptionsnow read these settings (minimap.enabled,guides.indentation,fontLigatures) so changes apply fluidly.#933 — Soroban SDK deprecation warnings (
extension/)Parses the
soroban-sdkversion from Cargo.toml manifests and raises a VS Code Problems-panel warning when it's outdated.extension/src/services/DeprecationChecker.ts— VS Code integration (DiagnosticCollection over Cargo.toml; Warning for deprecated, Information for outdated).extension/src/services/DeprecationChecker.core.ts— pure,vscode-free parsing/comparison core (semver parse, manifest scan with line/col tracking, classification). Includes a crates.io latest-version lookup with an offline hardcoded fallback.extension.ts— registers the checker on activation.soroban-sdk = "x"and{ version = "x", features = [...] }forms; ignores git/path deps.Verified terminal output
#928 — store unit tests (vitest):
#933 — deprecation core verification (node):
tscis clean for all five new/changed files of mine. (Note: a fulltsc -p ./on the extension surfaces one pre-existing syntax error insrc/services/EventMonitor.tsthat is present onmainand unrelated to this PR.)Acceptance criteria