Add application icon, a couple more exceptions in gitignore#58
Open
LevBernstein wants to merge 2 commits into
Open
Add application icon, a couple more exceptions in gitignore#58LevBernstein wants to merge 2 commits into
LevBernstein wants to merge 2 commits into
Conversation
Contributor
Author
|
@0xf4b1 Please review; do you think this enhancement would improve the project? Thanks. I've found that the default login window is too small, so I resized that, and I added an icon for the window just for fun. |
Owner
|
hmm, I think this minor changes to the login app which actually only needs to be run once to get the token are not really necessary and the icon file still makes it path dependant |
Contributor
Author
|
At the very least, increasing the window size would make it easier to navigate, no? Not having to scroll would be nice. |
Owner
|
I cannot test at the moment.. I'm not aware that the login looks weird but I also haven't ran it since years because the token never expires once you have it 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the PlayerIcon file from Hearthstone_Data/Resources. I also increased the default window size for the login window, as I was getting annoyed at having to scroll.