ToA - Various Improvements and Fixes#1080
Open
Jin-Jiyunsun wants to merge 3 commits into
Open
Conversation
…e their usage is heavy - Improve textures in various rooms - Improve various lights - Improve various tile overrides - Add light back to unique/purple reward chest - Improve lighting on Tumeken's Shadow
Contributor
Author
|
Accidentally deleted an area definition at some point during this branches development, need to go back into ToA and fix that before this is ready |
- Fix missing area for loot room
Contributor
Author
|
Loot Room: 
Fixed the missing area, ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves various lights, textures and tile overides
I made the shadows a little longer in this room as I felt it fit the vibe better, also removed textures from the backing of walls and blending them into the sky box a better:
Added proper tile overrides to a bunch of the tiles missing them in this room, as well as fix it so the doors with the flames actually have their effect visible and not overwhelmed buy the attached light:
I also re added the light for when a purple/unique is obtained as I believe that the underlying bug was fixed since it was removed.
I tested this in leagues since theres guaranteed purples in invo 500s, and the light seemed to be behaving normally both when a purple dropped and in my solo runs where I did not get a purple, but this can be omitted if you think its going to be a problem still. Ill get a video of this next time I run the raid.