Skip to content

Fix missing export Fields type for Icon #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanlua wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing export Fields type for Icon #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Types.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ type Fields = {
notified: Signal,
}

export type Icon = Methods & StaticFunctions --typeof(setmetatable({} :: Fields, MT))
export type Icon = Methods & Fields & StaticFunctions --typeof(setmetatable({} :: Fields, MT))
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that Icon includes Fields, the event/property types in Fields become part of the public API. Several Signal generics in Fields don’t match how the library fires these events at runtime (e.g. toggled is fired with (boolean, fromSource, sourceIcon); selected/deselected are fired with (fromSource, sourceIcon); viewingStarted/viewingEnded are fired with a boolean; notified is fired with a noticeId). Please update the Fields signal type parameters to reflect the actual :Fire(...) signatures so typed consumers can receive the correct arguments.

Copilot uses AI. Check for mistakes.

export type StaticIcon = {
new: typeof(
Expand Down
Loading