Skip to content

feat(auto-restart): support StatefulSets and DaemonSets#272

Open
rotarur wants to merge 1 commit into
1Password:mainfrom
rotarur:main
Open

feat(auto-restart): support StatefulSets and DaemonSets#272
rotarur wants to merge 1 commit into
1Password:mainfrom
rotarur:main

Conversation

@rotarur

@rotarur rotarur commented Apr 24, 2026

Copy link
Copy Markdown

Extend the secret-update handler to restart StatefulSets and DaemonSets when a referenced Kubernetes secret is updated from 1Password, mirroring the existing Deployment behavior.

Handler changes:

  • add StatefulSetList and DaemonSetList to the polled workload types
  • extend getPodTemplate to return pod templates for both kinds

Test coverage:

  • generalize workload readback helpers (newEmptyWorkload, getPodTemplateAnnotations)
  • add StatefulSet cases for container env, volume, and auto-restart opt-out
  • add DaemonSet cases for container env, volume, and auto-restart opt-out

✨ Summary

🔗 Resolves:

✅ Checklist

  • 🖊️ Commits are signed
  • 🧪 Tests added/updated: (See the Testing Guide for when to use each type and how to run them)
    • 🔹 Unit
    • 🔸 Integration
    • 🌐 E2E (Connect)
    • 🔑 E2E (Service Account)
  • 📚 Docs updated (if behavior changed)

🕵️ Review Notes & ⚠️ Risks

Extend the secret-update handler to restart StatefulSets and DaemonSets
when a referenced Kubernetes secret is updated from 1Password, mirroring
the existing Deployment behavior.

Handler changes:

- add StatefulSetList and DaemonSetList to the polled workload types
- extend getPodTemplate to return pod templates for both kinds

Test coverage:

- generalize workload readback helpers (newEmptyWorkload, getPodTemplateAnnotations)
- add StatefulSet cases for container env, volume, and auto-restart opt-out
- add DaemonSet cases for container env, volume, and auto-restart opt-out
@rotarur

rotarur commented May 20, 2026

Copy link
Copy Markdown
Author

anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant