Draft
Conversation
- Update lsp4j and lsp4j.websocket.jakarta dependencies to 1.0.0 - Fix Diagnostic.getMessage() calls to use .getLeft() since message type changed from String to Either<String, MarkupContent> in lsp4j 1.0 - Fix affected files in main source: MissingSpaceDiagnostic, InvalidCharacterInFileDiagnostic, TSLintReportEntry, JUnitTestSuites, CodeQualityReportEntry, SarifReporter, GenericIssueReport - Fix affected test files: all diagnostic tests using getMessage(), DiagnosticAssert utility, IdenticalExpressionsDiagnosticTest Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
Add DiagnosticMessageSerializer and DiagnosticMessageDeserializer to handle the new Either<String, MarkupContent> message type in lsp4j 1.0.0 during JSON (de)serialization, following the same pattern as DiagnosticCodeSerializer/Deserializer. Update DiagnosticMixIn to register these for the message field. Co-authored-by: nixel2007 <1132840+nixel2007@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update lsp4ij to version 1.0
Update Eclipse LSP4J from 0.24.0 to 1.0.0
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LSP4J 1.0.0 implements LSP 3.18.0 and removes several deprecated APIs. The primary breaking change affecting this codebase is
Diagnostic.getMessage()now returningEither<String, MarkupContent>instead ofString.Dependency bump
org.eclipse.lsp4jandorg.eclipse.lsp4j.websocket.jakarta:0.24.0→1.0.0Adapt to
Diagnostic.messagetype changeAll call sites reading
diagnostic.getMessage()now call.getLeft()to extract the string:Affected main sources:
MissingSpaceDiagnostic,InvalidCharacterInFileDiagnostic,TSLintReportEntry,JUnitTestSuites,CodeQualityReportEntry,SarifReporter,GenericIssueReport. Same pattern applied across 14 test files andDiagnosticAssert.Jackson serialization for
Either<String, MarkupContent>Added
DiagnosticMessageSerializer/DiagnosticMessageDeserializer(mirroring the existingDiagnosticCodeSerializer/DiagnosticCodeDeserializer) and registered them inDiagnosticMixInso JSON reporters serialize/deserialize the message as a plain string.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.