Skip to content

test(tui): satisfy iteration-maturity gate in todo completion fixtures - #788

Merged
1jehuang merged 1 commit into
masterfrom
test/preserve-iteration-maturity-fixtures
Aug 4, 2026
Merged

test(tui): satisfy iteration-maturity gate in todo completion fixtures#788
1jehuang merged 1 commit into
masterfrom
test/preserve-iteration-maturity-fixtures

Conversation

@1jehuang

@1jehuang 1jehuang commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve the remaining local-master todo completion fixture updates
  • cover iteration-maturity gating across remote reload and state-model poke tests

This was the final local-only commit preventing the checkout from fast-forwarding to remote master.

--- — Jcode agent (automated triage), on behalf of @1jehuang

The iteration-maturity gate (d5acf5d) made delivery_state_passes require
autonomy and iteration_maturity too, so completion-cycle tests whose goals
only set delivery_state started tripping the ownership gate. Give those
fixtures passing goals, pin auto_poke_default_on=false where the test is
about disarm-on-clean-cycle, and make the completed_cycle history climb
one level so it does not read as a confidence spike.
@1jehuang
1jehuang merged commit aadd92f into master Aug 4, 2026
8 of 12 checks passed
@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates TUI auto-poke test fixtures for the newer todo completion maturity gates. The main changes are:

  • Added passing goal maturity fixtures to remote reload auto-poke tests.
  • Updated local finish-turn tests to include autonomy and iteration maturity state.
  • Pinned default-on auto-poke state in tests that assert clean-cycle disarming behavior.

Confidence Score: 5/5

Safe to merge with minimal risk.

Changes are limited to test fixtures and assertions. The added maturity-goal setup matches the gated behavior these tests are meant to cover. No runtime code or dependency changes were introduced.

Files Needing Attention: No files require special attention.

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex reviewed the primary transcript to confirm Cargo ran up to compilation progress and no CARGO_EXIT_STATUS was written before the outer validation timed out.
  • T-Rex inspected the timeout evidence to confirm the final Cargo exit was unknown due to the outer timeout and noted the tail of the Cargo log with active Cargo and rustc processes still compiling.
  • T-Rex observed that compilation remained active around tract-onnx, jcode-embedding, and jcode-base, while no failing test lines or Rust diagnostics appeared in the captured output.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
crates/jcode-tui/src/tui/app/tests/remote_events_reload_01/part_02.rs Adds passing goal maturity fixtures so remote auto-poke confidence gate tests exercise the intended todo confidence branches.
crates/jcode-tui/src/tui/app/tests/remote_events_reload_05.rs Updates reload and auto-poke regression tests with passing maturity goals and default-on state pinning for the intended scheduler behavior.
crates/jcode-tui/src/tui/app/tests/state_model_poke_03.rs Updates local finish-turn auto-poke fixtures to satisfy goal maturity gates and isolate confidence-spike challenge assertions.

Sequence Diagram

sequenceDiagram
participant Test as TUI regression test
participant Todo as todo storage
participant App as App scheduler / finish_turn
participant Queue as queued follow-up state

Test->>Todo: save completed todo fixture
Test->>Todo: save passing goal maturity fixture
Test->>App: finish turn or schedule_auto_poke_followup_if_needed()
App->>Todo: load todos and goals
App->>App: evaluate completion, maturity, and confidence gates
alt confidence or digest gate still needs work
    App->>Queue: enqueue hidden/system follow-up
else clean completed cycle
    App->>Queue: leave queue empty
    App->>App: disarm or re-arm based on default-on state
end
Loading

Reviews (1): Last reviewed commit: "test(tui): satisfy iteration-maturity ga..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant