test(tui): satisfy iteration-maturity gate in todo completion fixtures - #788
Merged
Merged
Conversation
The iteration-maturity gate (d5acf5d) made delivery_state_passes require autonomy and iteration_maturity too, so completion-cycle tests whose goals only set delivery_state started tripping the ownership gate. Give those fixtures passing goals, pin auto_poke_default_on=false where the test is about disarm-on-clean-cycle, and make the completed_cycle history climb one level so it does not read as a confidence spike.
Greptile SummaryThis PR updates TUI auto-poke test fixtures for the newer todo completion maturity gates. The main changes are:
Confidence Score: 5/5Safe to merge with minimal risk. Changes are limited to test fixtures and assertions. The added maturity-goal setup matches the gated behavior these tests are meant to cover. No runtime code or dependency changes were introduced. Files Needing Attention: No files require special attention.
What T-Rex did
|
| Filename | Overview |
|---|---|
| crates/jcode-tui/src/tui/app/tests/remote_events_reload_01/part_02.rs | Adds passing goal maturity fixtures so remote auto-poke confidence gate tests exercise the intended todo confidence branches. |
| crates/jcode-tui/src/tui/app/tests/remote_events_reload_05.rs | Updates reload and auto-poke regression tests with passing maturity goals and default-on state pinning for the intended scheduler behavior. |
| crates/jcode-tui/src/tui/app/tests/state_model_poke_03.rs | Updates local finish-turn auto-poke fixtures to satisfy goal maturity gates and isolate confidence-spike challenge assertions. |
Sequence Diagram
sequenceDiagram
participant Test as TUI regression test
participant Todo as todo storage
participant App as App scheduler / finish_turn
participant Queue as queued follow-up state
Test->>Todo: save completed todo fixture
Test->>Todo: save passing goal maturity fixture
Test->>App: finish turn or schedule_auto_poke_followup_if_needed()
App->>Todo: load todos and goals
App->>App: evaluate completion, maturity, and confidence gates
alt confidence or digest gate still needs work
App->>Queue: enqueue hidden/system follow-up
else clean completed cycle
App->>Queue: leave queue empty
App->>App: disarm or re-arm based on default-on state
end
Reviews (1): Last reviewed commit: "test(tui): satisfy iteration-maturity ga..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This was the final local-only commit preventing the checkout from fast-forwarding to remote master.
--- — Jcode agent (automated triage), on behalf of @1jehuang