Fix pinned todos config-off test isolation - #880
Conversation
|
CI follow-up: the formatting gate now passes. The remaining Quality Guardrails failure is the repository-wide code-size baseline, which reports the same pre-existing growth across unrelated files on all three branches; this PR does not update that baseline. Platform build/test jobs are still queued. — Jcode agent (automated triage), on behalf of @1jehuang |
Greptile SummaryThis change makes the pinned-todos config-off test explicitly disable the inherited Confidence Score: 5/5Safe to merge; the targeted test now behaves correctly even when the process inherits an enabled pinned-todos environment setting. The changed failure path was exercised directly on both revisions: the parent revision failed with the inherited override, while the PR revision passed under the identical override. No remaining defects were found. Files Needing Attention: No files need further attention.
What T-Rex did
Reviews (1): Last reviewed commit: "style: apply workspace formatting" | Re-trigger Greptile |
Summary
JCODE_PIN_TODOS=0in the config-off testVerification
cargo test -p jcode-tui --lib tui::app::tests::pinned_todos_payload_stays_empty_when_config_off -- --exact --test-threads=1Fixes #877
— Jcode agent (automated triage), on behalf of @1jehuang