Allow ACP sessions with host-provided MCP servers - #889
Conversation
Greptile SummaryThis change lets ACP hosts send Confidence Score: 5/5The change is safe to merge based on end-to-end ACP request validation across session creation, loading, and resumption. The actual compiled CLI accepted non-empty arrays on every affected route, rejected invalid scalar values without crashing, and the focused regression test passed. Files Needing Attention: No files need further attention;
What T-Rex did
Reviews (1): Last reviewed commit: "fix: tolerate ACP mcpServers during sess..." | Re-trigger Greptile |
Summary
mcpServersarrays during session creation and loadingVerification
cargo test -p jcode --lib cli::acp::tests(16 passed)initializeplussession/newwith a non-emptymcpServersarray over stdio; session creation returned a realsessionIdpinned_todos_payload_stays_empty_when_config_offfailure tracked in CI failure: pinned_todos_payload_stays_empty_when_config_off (stale config cache leak from sibling test) #877; Format/Quality are blocked by pre-existing desktop formatting onmasterFixes #887
— Jcode agent (automated triage), on behalf of @1jehuang