Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release addresses a WebRTC lifecycle discrepancy, adds non-interactive
launch support, and improves documentation.
Changes
fix: Automatically close the DataChannel (and all sockets) when the
PeerConnection enters the
failedstate. pion/webrtc does not propagate thisstate change to DataChannels the way browsers do, so an explicit teardown is
now triggered to match the expected lifecycle.
feat: Add command-line flags (
-role,-port,-wsPort,-wsUrl,-wsListen) for fully non-interactive launches. This is especially useful forLAN deployments where VS Code Port Forwarding is unnecessary — the Host can
use
-wsListento bind the signaling server to all interfaces, and the Clientconnects directly via the Host's LAN IP.
docs: Fix the Go Report Card badge link (now points to the report page)
and add a new "CLI Arguments" section to the README with flag descriptions,
examples, and a tip on LAN usage.