Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition in the signaling phase where a successfully
established tunnel could be incorrectly torn down immediately after
connection.
Root Cause
After the WebRTC DataChannel opens, the host's deferred
wsConn.Close()fires and propagates a read error to the client's
r.watch()goroutine.On a LAN, this error arrives within milliseconds of the DataChannel open
event, leaving the
selectinEstablishAsClient(andEstablishAsHost)with two ready cases simultaneously:
tr.Ready()anderrCh.Go's
selectresolves ties pseudo-randomly, so roughly 50% of CLI-modeLAN connections were terminated with a false "failed to read signaling
messages" error — even though the tunnel was healthy.
Fix
Added a non-blocking
tr.Ready()check inside theerrChcase of bothEstablishAsHostandEstablishAsClient. If the DataChannel is alreadyopen when the WS error is received, the error is treated as an expected
post-handshake cleanup rather than a failure.