Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the WebRTC signaling handshake by introducing a dual-flag mechanism to ensure both peers confirm that their DataChannels are open before proceeding. This improves the reliability of connection establishment by explicitly synchronizing readiness on both sides. Additionally, new logging and error handling have been added for better observability and robustness.
Key changes:
Dual-flag handshake for DataChannel readiness:
Introduced a new signaling message type (
msgTypeReady) to indicate when a peer's DataChannel is open, and updated both host and client flows to wait for this confirmation from the remote peer before finalizing the connection. (internal/signaling/message.go,internal/signaling/signaling.go,internal/signaling/receiver.go,internal/signaling/sender.go) [1] [2] [3] [4] [5] [6] [7] [8] [9]Updated the
receiverstruct to include apeerReadychannel and modified thewatchmethod to handle the newreadymessage type. (internal/signaling/receiver.go) [1] [2]Improved error handling and timeouts:
readyTimeout) when waiting for the peer's ready signal, and improved error handling and logging in both host and client establishment flows to handle negotiation failures and context cancellations more gracefully. (internal/signaling/signaling.go) [1] [2] [3] [4]Logging enhancements:
internal/signaling/ws.go,internal/signaling/signaling.go) [1] [2] [3] [4]