Skip to content

Add WoW Forever support and prepare RC3 - #54

Closed
Bl4ut0 wants to merge 7 commits into
2072:masterfrom
Bl4ut0:master
Closed

Bl4ut0 wants to merge 7 commits into
2072:masterfrom
Bl4ut0:master

Conversation

@Bl4ut0

@Bl4ut0 Bl4ut0 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add the WoW Forever interface 16001 hybrid client path, including Classic-era class/spell handling, modern restricted-aura handling, and AceDB 36 realm support.
  • Bring in the latest upstream 12.1 changes for restricted aura access, stale raid icons, and automatic debuff sound discovery.
  • Guard optional 12.1 restriction and aura-sound APIs; older client flavors retain their legacy scanner, and saved sound-setting call sites remain safe when sound registration is unavailable.
  • Keep debuff history and sound registration limited to public debuff names, types, and numeric spell IDs.
  • Replace the removed SetAuraBorder alias with the supported AuraContainer dispel-texture method and remove unused references to absent textures.
  • Add RC3 release notes and Forever compatibility/testing documentation.
  • Run package checks on pull requests and branches without publishing; reserve uploads for version tags.
  • Mark version tags containing -RC as GitHub prereleases, consistent with the prior Forever RCs.

Compatibility and verification

  • Target package interfaces: Retail 120100, Classic 11509, BCC 20506, Titan 38002, Mists 50504, and Forever 16001.
  • Final fork workflow run 36093866213 passed luacheck, all six package steps, the Forever archive verifier, and artifact upload.
  • Tagged Forever RC3 run 36093442912 passed its Forever package and archive checks; both full and no-lib archives are attached to the RC3 prerelease.
  • CurseForge upload was skipped because no usable CurseForge API token was available to the fork workflow.
  • Static path audit: all 20 TOC entries resolve; all 29 XML script/include paths resolve locally or through one of 18 declared packager externals; all three explicit add-on asset references resolve.
  • Live in-game coverage is still needed across dispelling classes and group/combat states; this remaining RC work is documented in FOREVER.md.

@2072

2072 commented Sep 25, 2026

Copy link
Copy Markdown
Owner

Thanks for your work, I cannot merge this directly (too many changes) but I will cherry pick from it and add you as co-author in the notes. This will definitely save me a lot of time!

@Bl4ut0

Bl4ut0 commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Happy to help even if it's a little. Had a guild member ask for decursive. And I was like sure why not. And threw together a port so if you can use any of it then perfect. Most of it is just check states to see if it's forever and of it is to not load that section that's not supported. I didn't dive super hard into your design style.i tried to stay away from removing anything It was more just to get it functioning. While keeping all the previous version support. But if it can help you get a leg up in your forever release then that's what matters to me :).

2072 added a commit that referenced this pull request Sep 25, 2026
(Cherry Picking of 388178a from Pull Request #54)

#skipall

Co-authored-by: Alex Mammen <Bl4ut0@gmail.com>
2072 added a commit that referenced this pull request Sep 25, 2026
Also clean up WOW flavors constants and rename DC.TWELVE_ONE to DC.RESTRICTED_AURAS and fix usages accordingly (use it instead of DC.MN when checking for API).

(Cherry Picking/adaptations of Pull Request #54 commit 1c20b00)

Co-authored-by: Alex Mammen <Bl4ut0@gmail.com>
2072 added a commit that referenced this pull request Sep 25, 2026
(Cherry Picking/adaptations of Pull Request #54 commit 0cb1fab)

Co-authored-by: Alex Mammen <Bl4ut0@gmail.com>
@2072

2072 commented Sep 25, 2026

Copy link
Copy Markdown
Owner

It should be OK now, I don't think I forgot anything apart from the packaging changes (I see that you changed some versions and stuff but since it's working, I don't want to touch it but don't hesitate to make a separate pull request for those if you feel like it), if you can test (btw, sorry for the confusion about DC.MN and DC.TWELVE_ONE, I see it caused you some troubles. It should be much clearer now.)

@Bl4ut0

Bl4ut0 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

With release of RC3 ill close this tract. if I see anything else I can help with ill make a separate PR for that!! Keep up the great work!!

@Bl4ut0 Bl4ut0 closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants