01a083c7 - Require a Lightning Address before forum posts - #145
Conversation
Forum compose now opens the requirements overlay when lightning-address is missing (no Skip). Contact still only needs rules and name.
The overlay title matches the rest of the catalog and drops Lightning jargon.
Dialog queries now use the catalog title instead of Lightning jargon.
CI lint failed on a long Wallet of Satoshi dialog query.
GitHub CI lost a race: the busy flag was still set when the retry click ran.
|
EN: DE: DetailsPass 1 asked for Wallet of Satoshi overlay copy and a CONTRIBUTING tree comment. A demand for new visual variants of RequirementsOverlay was rejected: name/rules overlays are also uncatalogued. Pass 2 aligned tests with that copy. Pass 3 flushed a GitHub-only PM-busy race in MemberProfileScreen tests. No open PR comments or review threads. mergeable=MERGEABLE. All six GitHub CI jobs succeeded at ff04ccb. |
Forum post without a Wallet of Satoshi address is a distinct UI state. Catalog, handbook, visual spec, and Linux Chromium shots cover the overlay.
A reply without a Wallet of Satoshi address is a distinct state of the member profile. Catalog, handbook, visual spec, and Linux Chromium shots cover the overlay.
|
EN: DE: DetailsHead Pass 1 (previous head): quality asked for a Pass 2: 0 counted defects. One quality note on No unresolved review threads. No inline comments. |
2 participants
EN:
Forum posts now require a Lightning Address. The overlay asks for it without Skip; contact messages still only need a name and the living-room rules.
/welcomeand/members/[accountId]now have overlay-address screenshot baselines.DE:
Forum-Posts brauchen jetzt eine Lightning-Adresse. Das Overlay fragt danach ohne Skip; Kontakt bleibt bei Name und Wohnzimmerregeln.
/welcomeund/members/[accountId]haben jetzt Overlay-Address-Screenshot-Baselines.Details
nextPostRequirementis rules, then name, then lightning-address.ContactLoaderusesnextContactRequirement(rules then name only). Onboarding Skip on/setup/addressis unchanged so members can still read the living room.Variants
overlay-addresson/welcomeand/members/[accountId]are catalogued inscripts/screen-variants.mjs, documented in the handbook, asserted in e2e, and have four Linux Chromium baselines each (desktop/mobile×light/dark).