Repository navigation
fix: align card response and member role contracts - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card updates declared
tagsas a scalar even though Kaiten returns tag objects, preventing consumers from typing the response consistently with card reads. CorrectCardsUpdateCardResponse.tagsto an optionalCardTagSummary[]. Restrict the member-role request and positional method argument to the only supported value,2(responsible).English and Russian REST guides explain the corrected contracts. Include package/lockfile version 1.0.3 for the requested patch release. Consumers that passed unsupported role values now receive a TypeScript error.
Validation: build, lint, formatting and bilingual documentation build passed. A TypeScript proof accepts tag arrays and role 2 while rejecting scalar tags and unsupported roles at both body and method boundaries. Primary schemas: https://developers.kaiten.ru/cards/update-card and https://developers.kaiten.ru/card-members/update-member-role.