fix: removed core-js from dependencies#209
Open
bal3no wants to merge 1 commit into2muchcoffeecom:masterfrom
Open
fix: removed core-js from dependencies#209bal3no wants to merge 1 commit into2muchcoffeecom:masterfrom
bal3no wants to merge 1 commit into2muchcoffeecom:masterfrom
Conversation
Contributor
Author
|
Hi, I've made this PR in relation to the issue regarding the deep import warning when compiling. I've removed the core-js package completely and used the Object.assign function instead because it was the only usage that i have found in the code. I don't know if there can be other use cases in wich the package is required. Let me know if this can be a valid fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.