Skip to content

test suite should pass - #15

Open
wenzowski wants to merge 5 commits into
2potatocakes:masterfrom
ent-io:feature/erb
Open

test suite should pass#15
wenzowski wants to merge 5 commits into
2potatocakes:masterfrom
ent-io:feature/erb

Conversation

@wenzowski

Copy link
Copy Markdown

a few minor tweaks I found necessary

I required 6c16b6e to use the default spec/support/google_storage.yml.

The other two commits are just cleanup.

@wenzowski

Copy link
Copy Markdown
Author

f9efe03 fools GoogleStorage into thinking it has a valid refresh_token, avoiding

RuntimeError: 
You need to acquire a refresh_token before you can make requests to the Google API

Doesn't change VCR matching, so specs pass.

@wenzowski

Copy link
Copy Markdown
Author

...and that PR failure completely confuses me. I had it passing.

@wenzowski

Copy link
Copy Markdown
Author

There's definitely still a matcher issue here, but rather than spend time debugging it, I added a class to auto-generate and track buckets used in the test suite as part of wip for #12. Now includes naieve teardown.

@wenzowski

Copy link
Copy Markdown
Author

there's no matcher issue, but a random execution order issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant