🧹 Groundskeeper: remove stray theme-export files - #336
Merged
Merged
Conversation
themes/Custom_Theme.json and themes/Custom_Theme_X.json are downloaded
output of the theme customizer's "save theme" feature (each carries a
savedAt timestamp), not source. They landed in an unrelated PR ("Put the
bundled sample apps one pick away from the host list") and nothing in the
codebase, docs, Dockerfile, or CI references a themes/ directory at the
repo root — the app's own theme persistence goes through the
/api/themes/save HTTP route, not a file on disk. Removing the stray
directory keeps the repo root free of test-session leftovers.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WD4Z7iK6f3tpZqgWnAsdYc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗂️ Clutter
themes/Custom_Theme.jsonandthemes/Custom_Theme_X.json— two JSON files at the repo root that are the downloaded output of the app's theme customizer "save theme" feature, not source. Each carries asavedAtISO timestamp (2026-02-14T11:16:15Z/...11:20:28Z) and acustomTheme/schema/themeshape matching the/api/themes/savepayload incmd/3270Web/main.go— i.e. someone's local test session leaked into a commit. They landed via PR #284, "Put the bundled sample apps one pick away from the host list," which is otherwise unrelated to theming — a clear sign of accidental inclusion rather than an intentional fixture.🔎 Verification
grep -rn "themes/" --include="*.mjs" --include="*.go" --include="*.js" --include="*.md" .(excluding node_modules) — the only hits are the/api/themes/saveroute string, not athemes/directory reference. The app persists themes over HTTP, never to a file at this path.mkdocs.yml,Dockerfile,docker-compose*.yml, and.github/for any mention of athemes/directory — none found.git log --oneline -- themes/shows exactly one commit (the unrelated merge above) ever touched this path — no later commit built on it.git ls-filesconfirms nothing else in the tree depends on these two files.🎯 Benefit
Removes two runtime-generated, non-source files that don't belong in the repository and could confuse a future contributor into thinking
themes/*.jsonis a real config or fixture directory.✅ Checks
go build ./...— cleango vet ./...— cleango test ./...— all packages pass (cmd/3270Web,internal/*)Other candidates noticed, not acted on
3270Web/3270Web.exeat the repo root (34–36 MB compiled binaries) — tracked deliberately per commit history ("Update binary files for 3270Web and 3270Web.exe"), last touched 2026-08-24 (within the 30-day window) — left alone.web/static/screen-copy.jsmatched the*-copy*filename heuristic but is a legitimate, actively-referenced feature file (whole-screen/rectangular clipboard copy) — left alone.🤖 Generated with Claude Code
https://claude.ai/code/session_01WD4Z7iK6f3tpZqgWnAsdYc
Generated by Claude Code