Skip to content

Ignore tmp/ media export directory to prevent accidental binary commits - #2

Merged
334456777 merged 2 commits into
mainfrom
copilot/fix-code-for-review-comment
Jun 5, 2026
Merged

Ignore tmp/ media export directory to prevent accidental binary commits#2
334456777 merged 2 commits into
mainfrom
copilot/fix-code-for-review-comment

Conversation

Copilot AI commented Jun 5, 2026

Copy link
Copy Markdown

The review feedback flagged that query.py media now defaults to a relative tmp/ output directory, but the repo was not ignoring that path. This creates commit risk for exported media artifacts.

  • What changed

    • Added tmp/ to .gitignore under generated/local-only outputs.
  • Why this addresses the review comment

    • Keeps query.py media default behavior intact while ensuring exported binaries in tmp/ are excluded from version control.
# Generated / local-only
chat-*.txt
chat_timeline.html
tmp/

@334456777
334456777 marked this pull request as ready for review June 5, 2026 00:58
Copilot AI review requested due to automatic review settings June 5, 2026 00:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI changed the title [WIP] Fix code based on review comment Ignore tmp/ media export directory to prevent accidental binary commits Jun 5, 2026
Copilot AI requested a review from 334456777 June 5, 2026 01:00
@334456777
334456777 merged commit 73c0bd5 into main Jun 5, 2026
@334456777
334456777 deleted the copilot/fix-code-for-review-comment branch June 5, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants