Skip to content

Chore/#494 이것저것 수정 #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
y-eonee merged 2 commits into from
Aug 18, 2026
Merged

Chore/#494 이것저것 수정 #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e8df86
refactor: #494 좋아요 true일 때만 집계되도록 수정
y-eonee Aug 18, 2026
435b0de
docs: #494 yml 파일 수정
y-eonee Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions .github/workflows/fastlane_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,27 @@
name: Fastlane CI

on:
push:
branches:
- release
pull_request:
branches:
- main
- release
- develop
types: [closed]

jobs:
fastlane:
name: Run Fastlane
runs-on: macos-latest
if: github.event.pull_request.merged == true

if: github.event_name == 'push' || github.event.pull_request.merged == true
defaults:
run:
working-directory: ./ByeBoo-iOS

steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
token: ${{ secrets.GITHUB_TOKEN }}

Expand All @@ -36,28 +42,24 @@ jobs:
- name: Run upload_testflight
if: github.event.pull_request.base.ref == 'develop'
env:
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
FASTLANE_PASSWORD: ${{ secrets.FASTLANE_PASSWORD }}
FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD: ${{ secrets.FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD }}
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_ID }}
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
APP_STORE_CONNECT_API_KEY_CONTENT: ${{ secrets.APP_STORE_CONNECT_API_KEY_CONTENT }}
APP_IDENTIFIER: ${{ secrets.APP_IDENTIFIER }}
FASTLANE_ITC_TEAM_ID: ${{ secrets.FASTLANE_ITC_TEAM_ID }}
TEAM_ID: ${{ secrets.TEAM_ID }}
PRIVATE_REPOSITORY: ${{ secrets.PRIVATE_REPOSITORY }}
MATCH_GIT_BASIC_AUTHORIZATION: ${{ secrets.MATCH_GIT_BASIC_AUTHORIZATION }}
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
DISCORD_URL: ${{ secrets.DISCORD_URL }}
run: bundle exec fastlane upload_testflight

- name: Run release_app_store on main
if: github.event.pull_request.base.ref == 'main'
- name: Run release_app_store on release
if: github.event_name == 'push' || github.event.pull_request.base.ref == 'release'
env:
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
FASTLANE_PASSWORD: ${{ secrets.FASTLANE_PASSWORD }}
FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD: ${{ secrets.FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD }}
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_ID }}
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
APP_STORE_CONNECT_API_KEY_CONTENT: ${{ secrets.APP_STORE_CONNECT_API_KEY_CONTENT }}
APP_IDENTIFIER: ${{ secrets.APP_IDENTIFIER }}
FASTLANE_ITC_TEAM_ID: ${{ secrets.FASTLANE_ITC_TEAM_ID }}
TEAM_ID: ${{ secrets.TEAM_ID }}
PRIVATE_REPOSITORY: ${{ secrets.PRIVATE_REPOSITORY }}
MATCH_GIT_BASIC_AUTHORIZATION: ${{ secrets.MATCH_GIT_BASIC_AUTHORIZATION }}
Expand Down
4 changes: 3 additions & 1 deletion ...eBoo-iOS/Presentation/Feature/Quest/ViewController/CommonQuestHistoryViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,9 @@ extension CommonQuestHistoryViewController {
let entity = result.entity
self?.rootView.questContentView.updateUI(likeCount: entity.likeCount, isLiked: entity.isLiked)

Mixpanel.mainInstance().track(event: CommonJourneyEvents.Name.commonJourneyLike)
if entity.isLiked {
Mixpanel.mainInstance().track(event: CommonJourneyEvents.Name.commonJourneyLike)
}
case .failure(let error):
ByeBooLogger.error(error)
}
Expand Down
4 changes: 3 additions & 1 deletion ...oo-iOS/Presentation/Feature/Quest/ViewController/CommonQuestMyAnswersViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,9 @@ extension CommonQuestMyAnswersViewController {
isLiked: entity.isLiked
)

Mixpanel.mainInstance().track(event: CommonJourneyEvents.Name.commonJourneyLike)
if entity.isLiked {
Mixpanel.mainInstance().track(event: CommonJourneyEvents.Name.commonJourneyLike)
}
case .failure(let error):
ByeBooLogger.error(error)
}
Expand Down
4 changes: 3 additions & 1 deletion ...-iOS/ByeBoo-iOS/Presentation/Feature/Quest/ViewController/CommonQuestViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ extension CommonQuestViewController {
let entity = result.entity
self?.updateLikeCount(answerID: result.answerID, likeCount: entity.likeCount, isLiked: entity.isLiked)

Mixpanel.mainInstance().track(event: CommonJourneyEvents.Name.commonJourneyLike)
if entity.isLiked {
Mixpanel.mainInstance().track(event: CommonJourneyEvents.Name.commonJourneyLike)
}
case .failure(let error):
ByeBooLogger.error(error)
}
Expand Down
Loading