Fix storage discover signature mismatch#39
Closed
erik777 wants to merge 1 commit into
Closed
Conversation
|
@erik777 / If you want to look over my attempts to keep this plugin up to date, that would certainly be appreciated. This is my PR, but since 39aldo39 seems to be gone, I have just made a release on my repo: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this:
Fix Radicale 3.3 storage discover signature mismatch
This updates
Storage.discover()inradicale_storage_decsyncto accept and forward the additionaluser_groupsargument expected by newer Radicale versions.Problem:
PROPFIND /discover()with an extra argumentStorage.discover() takes from 2 to 4 positional arguments but 5 were givenChange:
user_groupstoStorage.discover()user_groupsthrough tosuper().discover(...)Why this change:
Validation:
/.web/succeeds after this patchsource: #34