Skip to content

[PR #191/a09d320b backport][stable-10] charts - fix plotly 6.1.1 requirements #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NomakCooper merged 1 commit into from
May 27, 2025
Merged

[PR #191/a09d320b backport][stable-10] charts - fix plotly 6.1.1 requirements #192

NomakCooper merged 1 commit into from
May 27, 2025

Conversation

@patchback
Copy link
Contributor

@patchback patchback bot commented May 27, 2025

This is a backport of PR #191 as merged into main (a09d320).

SUMMARY

This PR removes charts module and install_dep role version restriction for plotly package.

charts module works correctly with plotly < 6.1.0 >= 6.1.1

Fixes #190

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

charts

ADDITIONAL INFORMATION

charts units and integration tests work fine

TASK [charts : Assert that all chart image files exist and are non-empty] ******
ok: [testhost] => {
    "changed": false,
    "msg": "All assertions passed"
}

@NomakCooper @patchback
charts - fix plotly 6.1.1 requirements (#191)
e25275e 
* charts - fix plotly 6.1.1 requirements

* charts - add new changelog fragments

(cherry picked from commit a09d320)
@ans2bot ans2bot bot added the needs_triage label May 27, 2025
@patchback patchback bot mentioned this pull request May 27, 2025
Merged
@ans2bot
Copy link

ans2bot bot commented May 27, 2025

cc @NomakCooper

@NomakCooper
Copy link
Contributor

NomakCooper commented May 27, 2025

/unlabel needs_triage

@ans2bot ans2bot bot added success CI Check Pass and removed needs_triage labels May 27, 2025
@github-actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://3A2DEV.github.io/ans2dev.general/branch/main

NomakCooper
NomakCooper reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@NomakCooper NomakCooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ans2bot[bot]
ans2bot bot approved these changes May 27, 2025
View reviewed changes
Copy link

@ans2bot ans2bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved by @NomakCooper

@NomakCooper NomakCooper merged commit df83ede into stable-10 May 27, 2025
32 checks passed
@NomakCooper NomakCooper deleted the patchback/backports/stable-10/a09d320b740ee829e4fb94a765421be7b46362f7/pr-191 branch May 27, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NomakCooper NomakCooper NomakCooper left review comments

@ans2bot ans2bot[bot] ans2bot[bot] approved these changes

Assignees

No one assigned

Labels

bug This issue/PR relates to a bug. docs_fragments module plugin roles success CI Check Pass tests units

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NomakCooper