Merged
Conversation
Prevent delocate from bundling libomp.dylib by adding --exclude libomp.dylib to the repair-wheel-command in pyproject.toml. Update simcoon-python-builder/CMakeLists.txt to set INSTALL_RPATH for the _core target on macOS to @loader_path, @loader_path/../../.., /usr/local/lib and /opt/homebrew/opt/libomp/lib so the wheel can find libsimcoon and system/conda/Homebrew libomp at runtime (keep BUILD_WITH_INSTALL_RPATH ON). This avoids shipping libomp in wheels and improves compatibility across CI, conda, and Homebrew environments.
Introduce a GitHub Actions workflow (fedoo-integration.yml) to run integration tests across multiple fedoo versions (0.7.0, 0.6.1, 0.6.0) and OS runners (Linux, macOS). The workflow installs system deps, builds and installs the simcoon wheel, installs fedoo, and runs tests; it also includes a macOS check to ensure libomp is not bundled. Add comprehensive pytest integration file tests/test_fedoo_integration.py exercising EPICP and Neo-Hookean behaviors, non-linear geometry, OpenMP-parallelized umat calls (including a threads parametrized test), and tangent/plasticity checks.
Add batch (Gauss-point) support to Rotation: introduce _is_batch and _voigt_* helpers, disallow converting batches to single _CppRotation, and vectorize mechanics methods (apply_stress/strain/stiffness/compliance/tensor and voigt rotation accessors) using NumPy einsum. Add unit tests covering batch operations and invariants in test_rotation.py. Integrate fedoo integration test steps into existing GitHub workflows (build.yml and ci.yml) for non-Windows runners and remove the dedicated fedoo-integration.yml workflow. Minor cleanups and docstring clarifications in tests/test_fedoo_integration.py.
Update CI workflows to install fedoo directly from the GitHub main branch instead of pinning to v0.8.0. build.yml: replace the pinned install with a git+https install and add a commented suggestion to use >=0.8.0 when released. ci.yml: add scikit-build-core, pybind11 and numpy to the install step, keep local package install, and install fedoo from the GitHub repo (with a commented line for >=0.8.0); both workflows continue to run the fedoo integration tests.
kmarchais
approved these changes
Mar 13, 2026
Member
kmarchais
left a comment
kmarchais
left a comment
There was a problem hiding this comment.
LGTM, when this will be merged, the main priority seems to release simcoon 1.11 so that fedoo 0.8 can be released too. Then it will be important to modify build.yml to test against the PyPI package of fedoo 0.8 and ci.yml to test against the conda package of fedoo 0.8
Member
Author
Yes, the temporary test on the fedoo pre-release branch will be updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to improve compatibility and reliability of the build process on macOS, specifically around handling shared libraries and dynamic linking for wheel and conda builds. The most important changes are:
macOS wheel build improvements:
repair-wheel-commandinpyproject.tomlto excludelibomp.dylibfrom bundled shared libraries, preventing potential conflicts with system or conda-provided versions.Dynamic library search path enhancements:
INSTALL_RPATHfor the_coretarget insimcoon-python-builder/CMakeLists.txton Apple platforms to include multiple locations wherelibomp.dylibmight be found, such as conda, Homebrew, and system directories, increasing the robustness of dynamic linking.