feat: Migrate expectation system to pgvector#127
Merged
Conversation
Integrate pgvector for semantic search on expectations: - V3 migration: pgvector extension, embedding vector(384) column, HNSW index - EmbeddingGenerator using all-MiniLM-L6-v2 via Candle (lazy-loaded, cached) - Duplicate detection at 85% cosine similarity threshold in expect command - Doctor command validates pgvector extension and expectations/pebbles schema - EmbeddingError variant for proper error semantics - Fix all clippy warnings and run cargo fmt across codebase Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8efb23407c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vector(384)embedding column with HNSW index to expectations tableEmbeddingGeneratorusingall-MiniLM-L6-v2via Candle (lazy-loaded, ~90MB on first run)buckets expectwarns when new expectation is >85% similar to existing onesbuckets doctorvalidates pgvector extension presence and expectations/pebbles schemabuckets setupoffers pgvector extension installationEmbeddingErrorvariant for proper error semanticsTest plan
cargo fmt --check— cleancargo clippy— zero warningscargo test— 204 tests pass (6 ignored: 2 embedding tests requiring model download, 3 Docker-dependent, 1 permission test)cargo test -- --ignored— run locally with Docker + network to verify embedding and DB testsbuckets doctorvalidates pgvector extensionbuckets expect "fast API"thenbuckets expect "quick API response"shows duplicate warning🤖 Generated with Claude Code