feat: import UI components from @4242labs/design-system package (42L-1913) - #79
Merged
Merged
Conversation
Predates the 2.4.5 rail/UI-contract refinement upstream: transition timing, the icon-collapse border fix, and hover text color on the inactive toggle. Folding it now so deleting the copy in favor of the package import changes no rendered byte (42L-1913, R7).
…1913) Bump the design-system pin to 2.4.10, delete the vendored ui/ copies and brand-mark, and repoint every importer at @4242labs/design-system/components/* instead of local paths. Adds the @source directive so Tailwind still scans the package's compiled classes. calendar, command, dialog and popover had drifted from the design system's current source, so this is a real rendered change for those four, not a byte-identical swap like the rest. Updates tests/test_ds_contract.py for package mode: no local ui/ copies left to exclude from the drift scan, and the compliance checker's pinned version is asserted separately from the DS_RELEASE dependency pin.
Contributor
This bump changes what the app renders
components
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@4242labs/design-systemto 2.4.10, deletes every vendored copy underweb/src/components/ui/andbrand-mark.tsx, and repoints all 14 external importers at@4242labs/design-system/components/*.@sourcedirective toindex.cssso Tailwind scans the package's compiled classes; adds the two package stylesheet imports.tests/test_ds_contract.pyfor package mode: no localui/copies remain to exclude from the app-owned drift scan, and the compliance checker's own pinned version (2.4.8, separate from the2.4.10dependency pin) is now asserted as its own constant.Visual change disclosure
calendar,command,dialogandpopoverhad drifted from the design system's current source before this migration. Switching them to the package import is not a byte-identical swap like the other 20 primitives — it is a real rendered change for these four. This follows the operator's Q1 decision to migrate them through the registry rather than eject, but the divergence itself has not been visually re-verified against a rendered surface, only diffed as source.Test plan
npm run buildandnpm run lintpass against the migrated treepytest tests/— 72 passedds-compliance.yml(dsjob — compliance checker, contract tests, Playwright a11y)🤖 Generated with Claude Code