Function strlcpy_is_not_posix truncated the last character of every s…#79
Open
luna7111 wants to merge 1 commit into42paris:masterfrom
Open
Function strlcpy_is_not_posix truncated the last character of every s…#79luna7111 wants to merge 1 commit into42paris:masterfrom
luna7111 wants to merge 1 commit into42paris:masterfrom
Conversation
…tring it copied. Removed the "- 1" in the loop so it copies the entire string.
Member
|
Hello, could you clarify that was the concret effect of this bug ? in what mlx functions ? |
Member
|
ok just saw your issue, but i need to make sure this does not break other things |
Author
|
hey! it's been a while since i made this PR. Seeing that you work at 42 Paris you must be very busy with other stuff so if you want me to take a better look at this and make tests for every call to this function just tell me, i have the time. Sorry if the issue and/or the PR weren't detailed enough, thank you for taking the time to take a look at the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78
Function strlcpy_is_not_posix truncated the last character of every string it copied. Removed the "- 1" in the loop condition so it copies the entire string.
Refer to the issue for a more in-detail description.
My login is ldel-val, slack me if you need to talk about this PR :)