add popover to no native attributes#164
Merged
Merged
Conversation
Owner
|
makes sense to me. super nice explanation btw, thanks for pointing out the references etc for sure saw the popover feature recently at a talk, looking forward to it :D |
43081j
approved these changes
Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upcoming
popoverfeature (spec PR: whatwg/html#8221, explainer: https://open-ui.org/components/popup.research.explainer) addspopoveras a global attribute to all HTMLElements. There is high confidence of good webcompat with this attribute (it used to be calledpopupbut that had webcompat issues).I think it would be good for
eslint-plugin-litto also introduce this. WebKit's standard position onpopoveris "support" (WebKit/standards-positions#74), as is Mozillas (mozilla/standards-positions#698). It has already been implemented in Chrome 106 behind a flag.