[fix] fix-issues-with-dart-analyze

docs/state-management.md

@@ -108,7 +108,7 @@ ProviderContainer(overrides: [
   packageInfoProvider.overrideWithValue(packageInfo),                // required if using App4Training
   fileSystemProvider.overrideWith((ref) => MemoryFileSystem()),      // optional
   httpClientProvider.overrideWith((ref) => mockClient),              // optional
-  languageProvider.overrideWith(() => TestLanguageController(...)),  // optional
+  languageProvider.overrideWith2((languageCode) => TestLanguageController(...)),  // optional
   languageStatusProvider.overrideWith(() => TestLanguageStatus()),   // optional
   backgroundSchedulerProvider.overrideWith(() => TestBackgroundScheduler()), // for /startup tests
 ])

docs/testing.md

@@ -92,7 +92,7 @@ testWidgets('...', (tester) async {
     overrides: [
       sharedPrefsProvider.overrideWithValue(prefs),
       packageInfoProvider.overrideWithValue(...),
-      languageProvider.overrideWith(() => TestLanguageController(initReturns: true)),
+      languageProvider.overrideWith2((languageCode) => TestLanguageController(initReturns: true)),
     ],
     child: const MaterialApp(
       locale: Locale('de'),

integration_test/background_interaction_test.dart

@@ -31,14 +31,22 @@ void main() async {
       // Waiting for the background task to finish its work
       completer.complete(data);
     });
-    await Workmanager().initialize(backgroundTask, isInDebugMode: false);
-    await Workmanager().registerOneOffTask("task-identifier", "testTask",
-        initialDelay: const Duration(seconds: 2));
-
-    await tester.pumpWidget(ProviderScope(overrides: [
-      sharedPrefsProvider.overrideWithValue(prefs),
-      packageInfoProvider.overrideWithValue(packageInfo)
-    ], child: const App4Training()));
+    await Workmanager().initialize(backgroundTask);
+    await Workmanager().registerOneOffTask(
+      "task-identifier",
+      "testTask",
+      initialDelay: const Duration(seconds: 2),
+    );
+
+    await tester.pumpWidget(
+      ProviderScope(
+        overrides: [
+          sharedPrefsProvider.overrideWithValue(prefs),
+          packageInfoProvider.overrideWithValue(packageInfo),
+        ],
+        child: const App4Training(),
+      ),
+    );
     expect(find.text('Loading'), findsOneWidget);
 
     // Wait for the background isolate to finish
@@ -62,15 +70,24 @@ void main() async {
     });
     var fileSystem = await createTestFileSystem();
 
-    await tester.pumpWidget(ProviderScope(overrides: [
-      sharedPrefsProvider.overrideWithValue(prefs),
-      packageInfoProvider.overrideWithValue(packageInfo),
-      fileSystemProvider.overrideWith((ref) => fileSystem),
-      // We need to mock DownloadAssetsController because we can't use a memory
-      // file system to test it (it uses dart:io, not the file package)
-      languageProvider.overrideWith(() => LanguageController(
-          assetsController: createMockDownloadAssetsController())),
-    ], child: const App4Training()));
+    await tester.pumpWidget(
+      ProviderScope(
+        overrides: [
+          sharedPrefsProvider.overrideWithValue(prefs),
+          packageInfoProvider.overrideWithValue(packageInfo),
+          fileSystemProvider.overrideWith((ref) => fileSystem),
+          // We need to mock DownloadAssetsController because we can't use a memory
+          // file system to test it (it uses dart:io, not the file package)
+          languageProvider.overrideWith2(
+            (languageCode) => LanguageController(
+              languageCode: languageCode,
+              assetsController: createMockDownloadAssetsController(),
+            ),
+          ),
+        ],
+        child: const App4Training(),
+      ),
+    );
     expect(find.text('Loading'), findsOneWidget);
     await tester.pumpAndSettle();
 
@@ -83,9 +100,12 @@ void main() async {
     Navigator.of(tester.element(find.byType(Scaffold))).pop();
     await tester.pumpAndSettle();
 
-    await Workmanager().initialize(backgroundTask, isInDebugMode: false);
-    await Workmanager().registerOneOffTask("task-identifier", "testTask",
-        initialDelay: const Duration(seconds: 2));
+    await Workmanager().initialize(backgroundTask);
+    await Workmanager().registerOneOffTask(
+      "task-identifier",
+      "testTask",
+      initialDelay: const Duration(seconds: 2),
+    );
 
     // Wait for the background isolate to finish
     final msg = await completer.future.timeout(const Duration(seconds: 10));

lib/background/background_task.dart

@@ -19,8 +19,10 @@ Future<void> writeLog(String message) async {
     debugPrint(message);
     final path = await getApplicationDocumentsDirectory();
     final file = File('${path.path}/background.log');
-    await file.writeAsString('${DateTime.now().toIso8601String()}: $message\n',
-        mode: FileMode.append);
+    await file.writeAsString(
+      '${DateTime.now().toIso8601String()}: $message\n',
+      mode: FileMode.append,
+    );
   } catch (e) {
     debugPrint('Error writing message $message to file: $e');
   }
@@ -52,7 +54,8 @@ Future<void> backgroundMain() async {
   final prefs = await SharedPreferences.getInstance();
 
   final ref = ProviderContainer(
-      overrides: [sharedPrefsProvider.overrideWithValue(prefs)]);
+    overrides: [sharedPrefsProvider.overrideWithValue(prefs)],
+  );
   await backgroundCheck(ref);
 
   // TODO: check automatic updates setting; if necessary check connectivity
@@ -66,12 +69,18 @@ Future<void> backgroundTestMain() async {
   final prefs = await SharedPreferences.getInstance();
   var fileSystem = await createTestFileSystem();
 
-  final ref = ProviderContainer(overrides: [
-    sharedPrefsProvider.overrideWithValue(prefs),
-    fileSystemProvider.overrideWith((ref) => fileSystem),
-    languageProvider.overrideWith(() => LanguageController(
-        assetsController: createMockDownloadAssetsController()))
-  ]);
+  final ref = ProviderContainer(
+    overrides: [
+      sharedPrefsProvider.overrideWithValue(prefs),
+      fileSystemProvider.overrideWith((ref) => fileSystem),
+      languageProvider.overrideWith2(
+        (languageCode) => LanguageController(
+          languageCode: languageCode,
+          assetsController: createMockDownloadAssetsController(),
+        ),
+      ),
+    ],
+  );
   await backgroundCheck(ref);
 }
 

lib/data/globals.dart

@@ -11,7 +11,7 @@ final packageInfoProvider = MustOverrideProvider<PackageInfo>();
 Provider<T> MustOverrideProvider<T>() {
   return Provider<T>(
     (_) => throw ProviderNotOverriddenException(),
-    retry: (_, __) => null, // Disable v3 automatic retry - must fail fast
+    retry: (_, _) => null, // Disable v3 automatic retry - must fail fast
   );
 }