[fix] revert-package-version#8
Merged
Merged
Conversation
The update of the package cause an unexpected side effect for our specific use case of how we download files from GitHub. Due to our source not providing a specific header regarding the total size of the package, the latest version of the code rejects it and we can't download anything from GitHub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
It was necessary to revert an upgrade due to a crash
that happens for our app.
I investigated on how to replace the package, but to fix it for now
I only changed the package version.
Further investigation will come soon, on how can we migrate this
dependency, if it's possible to remove it or not.
Why?
The update of the package cause an unexpected side effect for our
specific use case of how we download files from GitHub.
Due to our source not providing a specific header regarding
the total size of the package, the latest version of the code
rejects it and we can't download anything from GitHub
How?
For now I have reverted the dependency to a previous version.
Testing?
Screenshots (optional)
Anything Else?