fix: place resume seniority override at end#200
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Discord resume update confirmation UI so the seniority override select is added after the action buttons, ensuring buttons are presented before the dropdown in the interaction flow.
Changes:
- Moved
ResumeSeniorityOverrideSelectaddition to the end ofResumeUpdateConfirmationViewconstruction. - Added a unit test asserting the seniority override select is the last interactive control and all buttons precede it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/discord_bot/src/five08/discord_bot/cogs/crm.py |
Reorders view item construction so the seniority override select is appended after buttons. |
tests/unit/test_crm.py |
Adds a regression test to lock in interactive component ordering (buttons before the seniority select). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Placed the seniority override select at the end of construction so buttons are shown first in the resume confirmation flow.
Added a regression test to assert the override select is the last interactive control and all buttons precede it.
No functional payload updates were changed, only interaction order/flow behavior.
Related Issue
How Has This Been Tested?
Committed changes were linted by repo hooks during commit; full test suite was not run.