Skip to content

fix: place resume seniority override at end#200

Merged
michaelmwu merged 1 commit intomainfrom
michaelmwu/resume-seniority
Mar 9, 2026
Merged

fix: place resume seniority override at end#200
michaelmwu merged 1 commit intomainfrom
michaelmwu/resume-seniority

Conversation

@michaelmwu
Copy link
Member

Description

Placed the seniority override select at the end of construction so buttons are shown first in the resume confirmation flow.
Added a regression test to assert the override select is the last interactive control and all buttons precede it.
No functional payload updates were changed, only interaction order/flow behavior.

Related Issue

How Has This Been Tested?

Committed changes were linted by repo hooks during commit; full test suite was not run.

Copilot AI review requested due to automatic review settings March 9, 2026 20:11
@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

Warning

Rate limit exceeded

@michaelmwu has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 50 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2795edd5-fa59-4713-8c58-2b3a7022630a

📥 Commits

Reviewing files that changed from the base of the PR and between 24679e8 and 740e833.

📒 Files selected for processing (2)
  • apps/discord_bot/src/five08/discord_bot/cogs/crm.py
  • tests/unit/test_crm.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch michaelmwu/resume-seniority

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@michaelmwu michaelmwu merged commit 89c965a into main Mar 9, 2026
7 checks passed
@michaelmwu michaelmwu deleted the michaelmwu/resume-seniority branch March 9, 2026 20:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Discord resume update confirmation UI so the seniority override select is added after the action buttons, ensuring buttons are presented before the dropdown in the interaction flow.

Changes:

  • Moved ResumeSeniorityOverrideSelect addition to the end of ResumeUpdateConfirmationView construction.
  • Added a unit test asserting the seniority override select is the last interactive control and all buttons precede it.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/discord_bot/src/five08/discord_bot/cogs/crm.py Reorders view item construction so the seniority override select is appended after buttons.
tests/unit/test_crm.py Adds a regression test to lock in interactive component ordering (buttons before the seniority select).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants