Added documentation for filtering categories from WikiLinks#143
Conversation
5j9
reviewed
May 15, 2025
README.rst
Outdated
| wl | ||
| for wl | ||
| in parsed.wikilinks | ||
| if wl.title.partition(':')[0].strip() == "Category" |
Owner
There was a problem hiding this comment.
Two suggestions: 1. Add a .lower() here since the namespace is case-insensitive, and some Wikipedians tend to use the lowercase form, i.e., [[category:x]]. 2. It might also be helpful to include the κατηγορία example you provided in issue #142—perhaps by replacing == "Category" with in ('category', 'κατηγορία').
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 2268 2268
=========================================
Hits 2268 2268 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Perfect! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a note in
README.rstfor how to get the categories out of the list of WikiLinks. This is what it looks like when rendered by Sphinx:Closes #142