Skip to content

Preserve field value when transition validation fails #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
regiscamimura wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preserve field value when transition validation fails #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions django_enumfield/db/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,9 @@ def set_enum(self, new_value):
"for enum {enum}."
).format(value=new_value, enum=enum)
)
validators.validate_valid_transition(enum, old_value, new_value)
setattr(self, private_att_name, new_value)
self.__dict__[att_name] = new_value
# Run validation for new value.
validators.validate_valid_transition(enum, old_value, new_value)

def get_enum(self):
return getattr(self, private_att_name)
Expand Down
6 changes: 6 additions & 0 deletions django_enumfield/tests/test_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ def test_enum_field_save(self):
self.assertEqual(beer.state, BeerState.FIZZY)
beer.save()

def test_invalid_transition_preserves_previous_value(self):
person = Person.objects.create(status=PersonStatus.ALIVE)
with self.assertRaises(InvalidStatusOperationError):
person.status = PersonStatus.UNBORN
self.assertEqual(person.status, PersonStatus.ALIVE)

def test_enum_field_refresh_from_db(self):
lamp = Lamp.objects.create(state=LampState.OFF)
lamp2 = Lamp.objects.get(pk=lamp.id)
Expand Down